Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise and improve Jenkins tutorial #195

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Standardise and improve Jenkins tutorial #195

merged 7 commits into from
Oct 2, 2024

Conversation

javierdelapuente
Copy link
Contributor

@javierdelapuente javierdelapuente commented Sep 27, 2024 •
edited
Loading

Applicable spec:

Overview

Standarise the Jenkins tutorial with other tutorials and improve/fix the tutorial.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@erinecon erinecon added the documentation Improvements or additions to documentation label Sep 27, 2024
erinecon
erinecon reviewed Sep 27, 2024
View reviewed changes
Copy link
Contributor

@erinecon erinecon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent draft! I added some nitpick comments. Thanks for your work on this tutorial :)

@javierdelapuente javierdelapuente changed the title Try 1 to improve tutorial Standardise and improve Jenkins tutorial Sep 30, 2024
@javierdelapuente javierdelapuente marked this pull request as ready for review September 30, 2024 08:59
@javierdelapuente javierdelapuente requested a review from a team as a code owner September 30, 2024 08:59
@javierdelapuente javierdelapuente added the trivial This is a trivial PR label Sep 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Test coverage for c5c03a4

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/actions.py         29      0      4      0   100%
src/agent.py          119      0     20      0   100%
src/auth_proxy.py      52      0      8      0   100%
src/charm.py           89      0     14      0   100%
src/cos.py             20      0      0      0   100%
src/ingress.py         16      0      4      0   100%
src/jenkins.py        376      0     60      0   100%
src/pebble.py          25      0      2      0   100%
src/state.py          109      0     24      0   100%
src/timerange.py       30      0      6      0   100%
---------------------------------------------------------------
TOTAL                 865      0    142      0   100%

Static code analysis report

Run started:2024-10-01 13:06:28.123975

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 7513
  Total lines skipped (#nosec): 6
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

erinecon
erinecon reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@erinecon erinecon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tutorial looks great -- thank you for your time and effort :)

I approve of the documentation changes 👍
(Didn't officially approve since other files were changed in this PR) the other files are NOT related to prod code, will approve now

cbartz
cbartz reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@cbartz cbartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have one question

docs/tutorial/getting-started.md Show resolved Hide resolved
@javierdelapuente javierdelapuente merged commit 94521d9 into main Oct 2, 2024
26 checks passed
@javierdelapuente javierdelapuente deleted the improve-tutorial branch October 2, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erinecon erinecon erinecon approved these changes

@cbartz cbartz cbartz approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Libraries: Out of sync trivial This is a trivial PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javierdelapuente @cbartz @erinecon